Skip to content

Conversation

@mrrobot47
Copy link
Member

This pull request makes minor improvements to the Site_Letsencrypt.php helper by ensuring that the executeFirstRequest and executeRenewal methods consistently return true upon successful completion. This helps clarify the expected return value and can improve error handling or control flow in code that calls these methods.

  • Consistency improvements:
    • Added a return true; statement at the end of the executeFirstRequest method to explicitly indicate successful completion.
    • Added a return true; statement at the end of the try block in the executeRenewal method, before the exception handling, to signal successful execution.

@mrrobot47 mrrobot47 merged commit 3a75526 into EasyEngine:develop Sep 26, 2025
1 of 5 checks passed
@mrrobot47 mrrobot47 deleted the fix/cert-return branch September 26, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant